-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shmem Ports & Channel refactor development #307
Merged
killight98
merged 39 commits into
lava-nc:messaging_refactor_develop
from
hexu33:messaging_refactor_develop
Aug 19, 2022
Merged
Shmem Ports & Channel refactor development #307
killight98
merged 39 commits into
lava-nc:messaging_refactor_develop
from
hexu33:messaging_refactor_develop
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
hexu33
changed the title
Fix Shmem channel & port build issues & Add ChannelFactory
Shmem Ports & Channel refactor development
Aug 16, 2022
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
@hexu33 pls add api calling of Ports & Channel into |
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: Miao, Hongda <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
* Convert CppIn/Out/Ref/Var-Ports (#297) * Adding preliminary ports * Added CppPort and CppIOPort * Add preliminary classes for CppInPorts and CppOutPorts * Add preliminary code for CppRefPorts * Added preliminary CppVarPort class * Add derived classes for CppVarPort * Update namespace naming * Fix linting issues * Updated pybind11 for numpy arrays * Fixed cpplint issues * Added lambda functions * Fix linting issues in Ports.h and Abstract Port cc file * Added Python wrapper functions * Added Pybind dtype for AbstractPortImplementation * Added tranformer header file * Updated transformers with parameters * Add missing include in PyWrapper * Add namespace for ports.cc * Add different types of Read() * Add transformer include and null to constants * Swap naming of classes in PyWrapper * Test variant on return types * Added Python wrapper for transformer class * Comment out Out/Ref/VarPorts for debugging * Change to use template for Recv and Peek (CppInPort) * Using pointers for constants * Updated templates for all ports * Fixed issue with vectors * Fix linting issue * Uncomment in PyWrapper * Add AbstractPort, Port and Transformer to CMakeLists Co-authored-by: shaline-koh <[email protected]> * amend xport apis Signed-off-by: luoxiaoc <[email protected]> * add xport test Signed-off-by: luoxiaoc <[email protected]> * fix double free Signed-off-by: luoxiaoc <[email protected]> Signed-off-by: luoxiaoc <[email protected]> Co-authored-by: Wen Jie Seow <[email protected]> Co-authored-by: shaline-koh <[email protected]>
* Update shemchannel in pypychannel.py * Update Channel and Channel Type from message_infrastructure cpplib * update channel interface: Update message_infrastructure ChannelType to ChannelTransferType TODO: Update the relationship between SharedMem and SharedMemManager TODO: Offload Python CSPSelect to message_infrastructure cpplib * Update Service and Runtime Channel Builder Signed-off-by: Miao, Hongda <[email protected]>
Signed-off-by: hexu1 <[email protected]>
…3/lava_dev into messaging_refactor_develop
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Signed-off-by: luoxiaoc <[email protected]>
Signed-off-by: luoxiaoc <[email protected]>
Signed-off-by: luoxiaoc <[email protected]>
…3/lava_dev into messaging_refactor_develop
Signed-off-by: luoxiaoc <[email protected]>
hongdami
approved these changes
Aug 19, 2022
killight98
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information